nflverse / nflfastR

A Set of Functions to Efficiently Scrape NFL Play by Play Data
https://www.nflfastr.com/
Other
425 stars 52 forks source link

[BUG] probably not a real issue, i'm just dumb #490

Open morganandrew opened 2 hours ago

morganandrew commented 2 hours ago

Is there an existing issue for this?

Have you installed the latest development version of the package(s) in question?

If this is a data issue, have you tried clearing your nflverse cache?

I have cleared my nflverse cache and the issue persists.

What version of the package do you have?

4.6.1

Describe the bug

probably an issue with what i'm doing but my player ids in pbp data are random characters, like non-english stuff. sorry if this is just negligence on my end

Reprex

library(nflfastR)
library(tidyverse)
ids <- fast_scraper_schedules(2022) %>% filter(away_team == "DET") %>% pull(game_id)
pbp <- build_nflfastR_pbp(ids)
head(pbp$passer_player_id, 20)

Expected Behavior

should have id's in the 00-00xxxx format but instead has some random characters, like jared goff's passer_player_id is "GOF!\x966sT\xd2\xeb".

nflverse_sitrep

nflverse_sitrep()
── System Info ──────────────────────────────────────────────────────────────────────────────────────────────────────────────
• R version 4.3.2 (2023-10-31) • Running under: macOS Monterey 12.7.1
── Package Status ───────────────────────────────────────────────────────────────────────────────────────────────────────────
   package installed  cran        dev behind
1 nflfastR     4.6.1 4.6.1 4.6.1.9018    dev
2 nflreadr     1.4.1 1.4.1   1.4.1.04    dev
── Package Options ──────────────────────────────────────────────────────────────────────────────────────────────────────────
• No options set for above packages
── Package Dependencies ─────────────────────────────────────────────────────────────────────────────────────────────────────
• cachem      (1.0.8)    • grid       (4.3.2)    • purrr      (1.0.2)    
• cli         (3.6.2)    • hms        (1.1.3)    • R6         (2.5.1)    
• codetools   (0.2-19)   • janitor    (2.2.0)    • rappdirs   (0.3.3)    
• compiler    (4.3.2)    • jsonlite   (1.8.8)    • rlang      (1.1.3)    
• cpp11       (0.4.7)    • lattice    (0.21-9)   • snakecase  (0.11.1)   
• curl        (5.2.0)    • lifecycle  (1.0.4)    • splines    (4.3.2)    
• data.table  (1.14.10)  • listenv    (0.9.1)    • stats      (4.3.2)    
• digest      (0.6.33)   • lubridate  (1.9.3)    • stringi    (1.8.3)    
• dplyr       (1.1.4)    • magrittr   (2.0.3)    • stringr    (1.5.1)    
• fansi       (1.0.6)    • Matrix     (1.6-1.1)  • tibble     (3.2.1)    
• fastmap     (1.1.1)    • memoise    (2.0.1)    • tidyr      (1.3.1)    
• fastrmodels (1.0.2)    • methods    (4.3.2)    • tidyselect (1.2.0)    
• furrr       (0.3.1)    • mgcv       (1.9-0)    • timechange (0.2.0)    
• future      (1.34.0)   • nlme       (3.1-163)  • tools      (4.3.2)    
• generics    (0.1.3)    • parallel   (4.3.2)    • utf8       (1.2.4)    
• globals     (0.16.3)   • parallelly (1.38.0)   • utils      (4.3.2)    
• glue        (1.7.0)    • pillar     (1.9.0)    • vctrs      (0.6.5)    
• graphics    (4.3.2)    • pkgconfig  (2.0.3)    • withr      (2.5.2)    
• grDevices   (4.3.2)    • progressr  (0.14.0)   • xgboost    (1.7.8.1)  
── Not Installed ────────────────────────────────────────────────────────────────────────────────────────────────────────────
• nflseedR  • nflplotR    
• nfl4th    • nflverse    
──────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────

Screenshots

No response

Additional context

image
tanho63 commented 1 hour ago

Please install development versions of nflreadr and nflfastR, see the README pages for details