Issue with load_rosters

nflverse / nflreadr

Efficiently download nflverse data

https://nflreadr.nflverse.com/

Other

60 stars 13 forks source link

Issue with load_rosters #111

Closed tpenney89 closed 2 years ago

tpenney89 commented 2 years ago

Rosters appear to still be reflecting roster prior to draft and NFL Free Agency. for example, Chase Edmonds and Christian Kirk still appear to be active on ARI. Looking at the load_rosters function definition for nflreadr it looks like the api was last ran on 3/10/2022?

Screenshot should be attached

rosters_2022 <- filter(load_rosters(),position %in% c("QB","RB","WR","TE")) view(rosters_2022)

Screen Shot 2022-06-05 at 11 36 57 AM

tanho63 commented 2 years ago

Looks like the action is running but not saving to the release properly :( https://github.com/nflverse/nflfastR-roster/blob/master/src/update_roster.R

I should have time to fix this when I'm bored at work next

tanho63 commented 2 years ago

Resolved in nflverse/nflfastR-roster@8d778d4c63f0f99ac3fa8dc40c68b8b9549a95c5