FTN data dictionary improvements

nflverse / nflreadr

Efficiently download nflverse data

https://nflreadr.nflverse.com/

Other

58 stars 12 forks source link

FTN data dictionary improvements #216

Open tanho63 opened 1 year ago

tanho63 commented 1 year ago

[ ] read_thrown definitions: 1, 2, CHK check down, SD scramble drill, DES designed play (read 0, eg screens)
[ ] n_blitzers, n_pass_rushers
[ ] n_defense_box

Also:

[x] add trimws() to FTN and rebuild

mrcaseb commented 3 weeks ago

add trimws() to FTN and rebuild

Has this been implemented? Or is it actually necessary? I don't see any difference

p <- nflreadr::load_ftn_charting(TRUE)

c <- p |> dplyr::select(tidyselect::where(is.character))

s <- c |> dplyr::mutate_all(trimws)

waldo::compare(c, s)
#> ✔ No differences

^{Created on 2024-08-25 with reprex v2.1.1}

tanho63 commented 3 weeks ago

add trimws() to FTN and rebuild

Has this been implemented? Or is it actually necessary? I don't see any difference
p <- nflreadr::load_ftn_charting(TRUE)

c <- p |> dplyr::select(tidyselect::where(is.character))

s <- c |> dplyr::mutate_all(trimws)

waldo::compare(c, s)
#> ✔ No differences
Created on 2024-08-25 with reprex v2.1.1

Not that I can tell, so yeah can skip

mrcaseb commented 3 weeks ago

Maybe ftn fixed on their end.