Investigate data type consistency across files

nflverse / nflreadr

Efficiently download nflverse data

https://nflreadr.nflverse.com/

Other

60 stars 13 forks source link

Investigate data type consistency across files #31

Open tanho63 opened 3 years ago

tanho63 commented 3 years ago

Where should this responsibility live?

at the nflreadr level? (nflreadr coerces types)
at the file maintainer level?

Seems to be best at the file maintainer level so that type is set once and not when the user runs it...but that means we need to come up with an nflverse-level type dictionary

Relatedly: column naming (player? player_name? full_player_name? name? merge_name) etc

alecglen commented 1 year ago

Hey @tanho63, interested in whether you've given this further thought recently?

I ran into the column-naming inconvenience a bunch this week while making some updates to nfl_data_py, and I'm considering transforming them all within the module to standardize the outputs. But on the other hand, I value keeping the API close to nflreadr for the sake of inter-communication between R/Python users in the Discord.

tanho63 commented 1 year ago

column naming or data types? column naming is difficult because we'd need to either support backcompat or do some sort of warn/deprecation process which wouldn't be fast.

I'd broadly be in favour of at least determining a standardized naming scheme that we could move towards in the future, if you have something to propose there. Would likely belong in a new issue since this specific one is about ensuring consistency of doubles, ints, character etc