search

nflverse / nflverse-data

Automated nflverse data repository
https://www.nflverse.com
Creative Commons Attribution 4.0 International
197 stars 18 forks source link

[BUG] no Jalen Hurts for Philapdelphia Depth Chart (week 23) #21

Closed bullaspc closed 1 year ago

bullaspc commented 1 year ago

Is there an existing issue for this?

Have you installed the latest development version of the package(s) in question?

What version of the package do you have?

1.3.1

Describe the bug

there isn't a record for Jalen Hurts as qb in Philadelphia depth chart for week 23

Reprex

team_target <- "PHI"

depth_chart <- nflreadr::load_depth_charts(seasons = 2022) %>% 

  filter(club_code==team_target) %>% 
  filter(week == max(week))

Expected Behavior

a record showing Jalen hurts as qb for week 23

nflverse_sitrep

── System Info ───────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────
• R version 4.2.2 Patched (2022-11-10 r83330)   • Running under: Ubuntu 22.04.1 LTS
── nflverse Packages ─────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────
• nflreadr (1.3.1)  • nflseedR (1.1.0)  • nflplotR (1.1.0)  
• nflfastR (4.5.0)  • nfl4th   (1.0.2)  • nflverse (1.0.2)  
── nflverse Options ──────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────
No options set for nflreadr, nflfastR, nflseedR, nfl4th, nflplotR, and nflverse
── nflverse Dependencies ─────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────
• askpass     (1.1)     • hms        (1.1.2)     • proto        (1.0.0)    
• cachem      (1.0.6)   • httr       (1.4.4)     • purrr        (0.3.5)    
• cli         (3.4.1)   • isoband    (0.2.6)     • R6           (2.5.1)    
• codetools   (0.2-18)  • janitor    (2.1.0)     • rappdirs     (0.3.3)    
• colorspace  (2.0-3)   • jsonlite   (1.8.3)     • RColorBrewer (1.1-3)    
• cpp11       (0.4.3)   • labeling   (0.4.2)     • Rcpp         (1.0.9)    
• crayon      (1.5.2)   • lattice    (0.20-45)   • rlang        (1.0.6)    
• curl        (4.3.3)   • lifecycle  (1.0.3)     • rstudioapi   (0.14)     
• data.table  (1.14.6)  • listenv    (0.8.0)     • scales       (1.2.1)    
• digest      (0.6.30)  • lubridate  (1.9.0)     • snakecase    (0.11.0)   
• dplyr       (1.0.10)  • magick     (2.7.3)     • stringi      (1.7.8)    
• ellipsis    (0.3.2)   • magrittr   (2.0.3)     • stringr      (1.4.1)    
• fansi       (1.0.3)   • MASS       (7.3-58.1)  • sys          (3.4.1)    
• farver      (2.1.1)   • Matrix     (1.5-3)     • tibble       (3.1.8)    
• fastmap     (1.1.0)   • memoise    (2.0.1)     • tidyr        (1.2.1)    
• fastrmodels (1.0.2)   • mgcv       (1.8-41)    • tidyselect   (1.2.0)    
• furrr       (0.3.1)   • mime       (0.12)      • timechange   (0.1.1)    
• future      (1.29.0)  • munsell    (0.5.0)     • utf8         (1.2.2)    
• generics    (0.1.3)   • nlme       (3.1-160)   • vctrs        (0.5.1)    
• ggplot2     (3.4.0)   • openssl    (2.0.4)     • viridisLite  (0.4.1)    
• globals     (0.16.2)  • parallelly (1.32.1)    • withr        (2.5.0)    
• glue        (1.6.2)   • pillar     (1.8.1)     • xgboost      (1.6.0.1)  
• gsubfn      (0.7)     • pkgconfig  (2.0.3)       
• gtable      (0.3.1)   • progressr  (0.11.0)

Screenshots

No response

Additional context

No response

john-b-edwards commented 1 year ago

nflreadr::load_depth_charts() is designed to load pre-scraped depth charts from the NFL Data Exchange -- these are provided as is, and sometimes they will be missing data. I went in and confirmed that the depth chart for the Eagles for the specified week is consistent, and Hurts is missing on the data exchange as well.

Unfortunately, editing the depth charts from the data exchange to be 100% correct is beyond the scope of what this function seeks to do, so I will leave this as is.

A very minor aside -- I would review the guidelines for producing a reprex and potentially work with the {reprex} package in the future. In your provided reprex you use several functions (%>%, filter()) without loading in the required library first ({dplyr}).