nflverse / nflverse-data

Automated nflverse data repository
https://www.nflverse.com
Creative Commons Attribution 4.0 International
196 stars 18 forks source link

[BUG] Missing `roof` values for 2021 #35

Closed john-b-edwards closed 3 months ago

john-b-edwards commented 11 months ago

Is there an existing issue for this?

Have you installed the latest development version of the package(s) in question?

If this is a data issue, have you tried clearing your nflverse cache?

I have cleared my nflverse cache and the issue persists.

What version of the package do you have?

1.4.0.9

Describe the bug

PBP data is missing roof values for a significant number of 2021 games. This issue appears to only be limited to a subset of 2021 games, no other seasons appear to be affected.

Reprex

nflreadr::load_pbp(TRUE) |>
    dplyr::filter(is.na(roof)) |>
    dplyr::count(season) |>
    data.frame()
#>   season    n
#> 1   2021 4387

nflreadr::load_pbp(2021) |>
    dplyr::filter(is.na(roof)) |>
    dplyr::count(game_id) |>
    data.frame()
#>            game_id   n
#> 1  2021_01_JAX_HOU 206
#> 2  2021_01_PHI_ATL 191
#> 3  2021_01_SEA_IND 169
#> 4   2021_02_LA_IND 168
#> 5  2021_03_CAR_HOU 170
#> 6  2021_04_WAS_ATL 190
#> 7   2021_05_NE_HOU 169
#> 8  2021_06_HOU_IND 162
#> 9  2021_08_CAR_ATL 173
#> 10  2021_08_LA_HOU 178
#> 11 2021_08_TEN_IND 206
#> 12 2021_09_NYJ_IND 183
#> 13 2021_10_JAX_IND 182
#> 14  2021_11_NE_ATL 158
#> 15 2021_12_NYJ_HOU 168
#> 16  2021_12_TB_IND 184
#> 17 2021_13_IND_HOU 165
#> 18  2021_13_TB_ATL 186
#> 19 2021_14_SEA_HOU 191
#> 20  2021_15_NE_IND 164
#> 21 2021_16_DET_ATL 156
#> 22 2021_16_LAC_HOU 172
#> 23  2021_17_LV_IND 165
#> 24  2021_18_NO_ATL 162
#> 25 2021_18_TEN_HOU 169

Expected Behavior

The 2021 season should have complete roof values for these games.

nflverse_sitrep

blah

Screenshots

No response

Additional context

No response

john-b-edwards commented 3 months ago

This has been fixed:

nflreadr::load_pbp(TRUE) |>
    dplyr::filter(is.na(roof)) |>
    dplyr::count(season) |>
    data.frame()
#> [1] season n     
#> <0 rows> (or 0-length row.names)