nflverse / nflverse-data

Automated nflverse data repository
https://www.nflverse.com
Creative Commons Attribution 4.0 International
180 stars 16 forks source link

MIssing Games for PBP Participation #43

Closed jkap86 closed 3 months ago

jkap86 commented 3 months ago

Is there an existing issue for this?

Have you installed the latest development version of the package(s) in question?

If this is a data issue, have you tried clearing your nflverse cache?

I have cleared my nflverse cache and the issue persists.

What version of the package do you have?

1.4.0

Describe the bug

2023 Weeks 16-19 don't seem to have every game. For example, week 17 only has 3 games.

Reprex

library(nflreadr)

pbp <- load_participation() %>%
  filter(startsWith(nflverse_game_id, '2023_17'))

print(length(unique(pbp$nflverse_game_id)))

* Returns 3

Expected Behavior

Should return 16 (the number of games that week)

nflverse_sitrep

── System Info ─────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────
• R version 4.3.2 (2023-10-31 ucrt) • Running under: Windows 11 x64 (build 22631)
── Package Status ──────────────────────────────────────────────────────────────────────────────────────────────────────────────────────
   package installed  cran      dev behind
1 nflreadr     1.4.0 1.4.0 1.4.0.12    dev
── Package Options ─────────────────────────────────────────────────────────────────────────────────────────────────────────────────────
• No options set for above packages
── Package Dependencies ────────────────────────────────────────────────────────────────────────────────────────────────────────────────
• cachem     (1.0.8)   • glue     (1.7.0)  • grDevices (4.3.2)  
• cli        (3.6.2)   • memoise  (2.0.1)  • methods   (4.3.2)  
• curl       (5.2.0)   • rappdirs (0.3.3)  • stats     (4.3.2)  
• data.table (1.15.0)  • rlang    (1.1.3)  • tools     (4.3.2)  
• fastmap    (1.1.1)   • graphics (4.3.2)  • utils     (4.3.2)  
── Not Installed ───────────────────────────────────────────────────────────────────────────────────────────────────────────────────────
• nflfastR  • nfl4th    • nflverse  
• nflseedR  • nflplotR

Screenshots

No response

Additional context

No response

tanho63 commented 3 months ago

This is a data source issue, we no longer get consistent coverage for participation data from our scraping. Nothing on the horizon indicates this will resolve itself.