search

nflverse / nflverse-data

Automated nflverse data repository
https://www.nflverse.com
Creative Commons Attribution 4.0 International
197 stars 18 forks source link

[FEATURE REQ] Update headshot_url for 2024 Draft Class in NFL Roster database #44

Closed jmstew3 closed 3 months ago

jmstew3 commented 5 months ago

Is there an existing issue for this?

Is your feature request related to a problem? Please describe.

  1. Player profile headshot urls are missing for the 2024 NFL draft class in the NFL Rosters database. Would also be nice if those URLs were added to the Draft database.

Describe the solution you'd like

Add new player headshot image urls to the NFL Roster database for players who were taken in the 2024 NFL draft. Also, add a new table column for headshot url in the NFL Draft database.

Describe alternatives you've considered

I tried to access the base url for the player profile urls (https://static.www.nfl.com/image/private/f_auto,q_auto/league/...) to see if I could contribute, but I don't have access that server.

Additional context

No response

john-b-edwards commented 3 months ago

These headshots are not available yet from the NFL. You can check this yourself--Caleb William's NFL.com page does not have a headshot. So unfortunately, we can't provide links to headshots that don't yet exist.

As this is an issue on the NFL's end, and not anything with our code, I'm going to close this issue. If the NFL adds these headshots, I'm confident that our code will ingest the new headshots appropriate, but in the event that it doesn't, feel free to re-open this issue.