nflverse / nflverse-data

Automated nflverse data repository
https://www.nflverse.com
Creative Commons Attribution 4.0 International
197 stars 18 forks source link

load_players should have all IDs from load_roster and load_ff_playerids #7

Closed tanho63 closed 1 week ago

tanho63 commented 2 years ago

I believe we currently have it that IDs are joined onto load_rosters for backwards compat, but really our primary ID file should be load_players()

thoughts @john-b-edwards @mrcaseb ?

john-b-edwards commented 3 months ago

Did we decide on this or did we want to use nflreadr::load_ff_playerids() instead as the primary ID file?

tanho63 commented 3 months ago

We should make load_players the core for nflverse and tack on ff_playerids afterwards imo. This more or less fell through the cracks unfortunately

mrcaseb commented 1 month ago

Players data outsourced to https://github.com/nflverse/nflverse-players