search

nflverse / nflverse-pbp

builds play by play and player stats for nflverse/nflverse-data
Creative Commons Attribution 4.0 International
289 stars 66 forks source link

Question: rosters with new id? #14

Closed egor006 closed 4 years ago

egor006 commented 4 years ago

Does the roster data not include the new ids? Here is what I'm getting, am I missing something?

Index(['team.season', 'teamPlayers.displayName', 'teamPlayers.firstName', 'teamPlayers.middleName', 'teamPlayers.lastName', 'teamPlayers.suffix', 'teamPlayers.status', 'teamPlayers.positionGroup', 'teamPlayers.position', 'teamPlayers.nflId', 'teamPlayers.esbId', 'teamPlayers.gsisId', 'teamPlayers.birthDate', 'teamPlayers.homeTown', 'teamPlayers.collegeId', 'teamPlayers.collegeName', 'teamPlayers.jerseyNumber', 'teamPlayers.height', 'teamPlayers.weight', 'team.teamId', 'team.abbr', 'team.cityState', 'team.fullName', 'team.nick', 'team.conferenceAbbr', 'team.divisionAbbr', 'teamPlayers.headshot_url', 'teamPlayers.profile_url'], dtype='object')

guga31bb commented 4 years ago

No, we have not found a way to obtain roster data under the new NFL data system

mrcaseb commented 4 years ago

The function fast_scraper_roster() will return to nflfastR with this pull request: https://github.com/mrcaseb/nflfastR/pull/93