Closed numbersinfigures closed 11 months ago
I think this is caused by a typo in the logics here https://github.com/nflverse/nflverse-pbp/blob/e7547cd92edf747a1b847082e33c880f4ed229e0/R/update_pbp_participation.R#L14-L15 and here https://github.com/nflverse/nflverse-pbp/blob/e7547cd92edf747a1b847082e33c880f4ed229e0/R/update_pbp_participation.R#L42-L43
Logic should be
week = dplyr::case_when(
!!season < 2021 & week == 22 ~ 21,
!!season >= 2021 & week == 23 ~ 22,
TRUE ~ week
)
Is there an existing issue for this?
Have you installed the latest development version of the package(s) in question?
What version of the package do you have?
1.0.3
Describe the bug
This is basically the fraternal twin to closed issue nflverse/nflfastR#77 in the nflverse-pbp repository. The participation only dataset includes the Rams/Bengals Super Bowl, but the nflverse_game_id logged as "2021_23_LA_CIN". It's omitted when "include_pbp=TRUE", since play-by-play dataset likely has the game tagged as "2021_22_LA_CIN".
I believe all the other available Super Bowls are now included in both requests post-fix.
Reprex
Expected Behavior
nflverse_sitrep
Screenshots
No response
Additional context
No response