nflverse / nflverse-rosters

builds roster data for nflverse/nflverse-data
Other
20 stars 4 forks source link

Include Spotrac player IDs in roster.csv #29

Open nickwan opened 2 years ago

nickwan commented 2 years ago

Hello, can yall please have Spotrac ID support available somewhere to join on? The spotrac ID looks unique to their site (i.e. Larry Fitzgerald's Spotrac ID is 966, while his NFL ID is 2506106, esb ID is FIT437493, gsis ID is 00-0022921, and college ID is 2927)

Alternatively, if you ingest salary info into a roster file that would also be cool. bonus points for draft day info

tanho63 commented 2 years ago

IDs shouldn’t be too tricky aside from the usual name join BS. Contract data definitely a bit more involved.

Is OTC better than spotrac to store?

mrcaseb commented 2 years ago

I wrote a scraper that scrapes historical contract data from sites like this https://overthecap.com/contract-history/quarterback/

image

Data will look like this:

image

I think the OTC IDs are not the same as spotrac IDs. Do you guys think this data is valuable in the nflverse @tanho63 and @nickwan? We could automate the scraper and add a function in nflreadr to load all historical contracts.

tanho63 commented 2 years ago

100% useful!

mrcaseb commented 2 years ago

scraping all positions results in ~31k contracts fwiw

mrcaseb commented 2 years ago

I wrote a scraper that scrapes historical contract data from sites like this https://overthecap.com/contract-history/quarterback/ image

Data will look like this: image

I think the OTC IDs are not the same as spotrac IDs. Do you guys think this data is valuable in the nflverse @tanho63 and @nickwan? We could automate the scraper and add a function in nflreadr to load all historical contracts.

The current version of this data is now attached to this release https://github.com/nflverse/nflverse-data/releases/tag/otc_contract_data

tanho63 commented 2 years ago

Update: after some discussion about naming it's now actually here lol https://github.com/nflverse/nflverse-data/releases/contracts

Still TODO: gsis/nflverse id -> otc id