nflverse / nflverse-rosters

builds roster data for nflverse/nflverse-data
Other
20 stars 3 forks source link

Consistent height formatting #48

Closed john-b-edwards closed 1 year ago

john-b-edwards commented 1 year ago

We should probably ensure heights come through in a consistent format. Leaning towards storing height as inches in INT.

nflreadr::load_players() |>
    dplyr::pull(height) |>
    table()
#> 
#>       0-0 5-10 5-11  5-5  5-6  5-7  5-8  5-9  6-0  6-1 6-10  6-2  6-3  6-4  6-5 
#>    4    5 1244 1593    1   14   77  224  591 2083 2255    2 2592 2740 2280 1699 
#>  6-6  6-7  6-8  6-9   66   67   68   69   70   71   72   73   74   75   76   77 
#>  928  390  117   36    1    1    3    4   18   23   37   33   44   46   29   39 
#>   78   79   80 
#>   17    4    1