nflverse / nflverse-rosters

builds roster data for nflverse/nflverse-data
Other
20 stars 3 forks source link

many NAs in birth_date from load_rosters() #50

Closed KoalatyStats closed 1 year ago

KoalatyStats commented 1 year ago

Describe the bug When using the load_rosters(2000:2022) function, most of the values in birth_date are NA. (31942/47982 to be exact) Reprex

rosters <- nflreadr::load_rosters(2000:2022)
sum(is.na(rosters$birth_date))

Expected behavior Ideally, we would have few if any NAs for this variable.

Session information Please copy the output of sessionInfo() into the box below.

loaded via a namespace (and not attached):
 [1] tidyselect_1.1.1  janitor_2.1.0     purrr_0.3.4       listenv_0.8.0     splines_4.0.2     lattice_0.20-41  
 [7] snakecase_0.11.0  vctrs_0.3.8       generics_0.1.2    usethis_2.0.1     mgcv_1.8-31       utf8_1.2.2       
[13] rlang_0.4.10      pillar_1.6.1      glue_1.4.2        DBI_1.1.1         xgboost_1.4.1.1   modelr_0.1.8     
[19] lifecycle_1.0.0   stringr_1.4.0     fastrmodels_1.0.2 progressr_0.8.0   future_1.21.0     codetools_0.2-16 
[25] memoise_2.0.0     fastmap_1.1.0     parallel_4.0.2    curl_4.3.2        fansi_0.5.0       broom_0.7.8      
[31] furrr_0.2.3       Rcpp_1.0.7        nflreadr_1.3.0    backports_1.2.1   cachem_1.0.5      jsonlite_1.7.2   
[37] parallelly_1.27.0 fs_1.5.0          digest_0.6.27     stringi_1.7.3     dplyr_1.0.7       nflfastR_4.1.0   
[43] grid_4.0.2        cli_3.0.1         tools_4.0.2       magrittr_2.0.1    tibble_3.1.0      crayon_1.4.1     
[49] tidyr_1.1.3       pkgconfig_2.0.3   ellipsis_0.3.2    Matrix_1.2-18     data.table_1.14.0 lubridate_1.7.10 
[55] rstudioapi_0.13   assertthat_0.2.1  R6_2.5.0          globals_0.14.0    nlme_3.1-148      compiler_4.0.2 
tanho63 commented 1 year ago

Thanks! Is definitely a bug. In the meantime (as prev discussed) please check out load_ff_playerids() as an option for (fantasy-relevant) birthdates.

tanho63 commented 1 year ago

Improved by #54, feel free to open a new issue if issues persist