nflverse / nflverse-rosters

builds roster data for nflverse/nflverse-data
Other
20 stars 3 forks source link

String formatting issue in `headshot` field of all `weekly_rosters` data #51

Closed maxbolger closed 1 year ago

maxbolger commented 1 year ago
  1. Have you installed the latest development version of the package(s) in question? Yes

  2. Describe the bug Likely string formatting issue in headshot field of weekly_rosters data

  3. Reprex

    Example of a value from the headshot field

https://static.www.nfl.com/image/private/{formatInstructions}/league/xw0jhb7zeobj4bkxfpwg



4. **Expected Behaviour** 
Parameters probably should have been passed via `formatInstructions`
<!-- A clear and concise description of what you expected to happen. -->

5. **nflverse_sitrep()** 
N/A

6. **Screenshots**
<!-- If applicable/helpful for your problem -->

<img width="663" alt="headshot_error" src="https://user-images.githubusercontent.com/67761101/184681848-88e5ddd9-aa13-4448-b97d-e259610852c9.png">

7. **Additional context**
N/A

<!-- If applicable -->
tanho63 commented 1 year ago

Thanks! Transferring to code repo. You're probably right, will consult @john-b-edwards after he returns from vacay.

mrcaseb commented 1 year ago

See https://github.com/nflverse/nflverse-rosters/blob/3efb051dc38a2579b880c199cfd6accecf009c7f/src/update_roster.R#L13-L17

tanho63 commented 1 year ago

Resolved by #54