Load Rosters full name col issue

[Jeffery-777]

Describe the bug For many older seasons, many players like Russell Wilson, Jameis Winston etc. show years in which their "full_name" column only shows first name.

Reprex

Russell Wilson example

load_rosters(1999:2022) %>% 
  filter(gsis_id == "00-0029263") %>% 
  select(season, full_name)

Session information Please copy the output of sessionInfo() into the box below.

R version 4.1.1 (2021-08-10)
Platform: x86_64-w64-mingw32/x64 (64-bit)
Running under: Windows 10 x64 (build 22000)

Matrix products: default

locale:
[1] LC_COLLATE=English_United States.1252  LC_CTYPE=English_United States.1252   
[3] LC_MONETARY=English_United States.1252 LC_NUMERIC=C                          
[5] LC_TIME=English_United States.1252    

attached base packages:
[1] stats     graphics  grDevices utils     datasets  methods   base     

other attached packages:
 [1] forcats_0.5.1   stringr_1.4.0   dplyr_1.0.7     purrr_0.3.4     readr_2.0.2     tidyr_1.1.4    
 [7] tibble_3.1.5    ggplot2_3.3.5   tidyverse_1.3.1 nflreadr_1.3.0 

loaded via a namespace (and not attached):
 [1] tidyselect_1.1.2  xfun_0.26         haven_2.4.3       colorspace_2.0-2  vctrs_0.3.8      
 [6] generics_0.1.2    htmltools_0.5.2   yaml_2.2.1        utf8_1.2.2        rlang_1.0.2      
[11] pillar_1.7.0      glue_1.6.2        withr_2.5.0       DBI_1.1.1         dbplyr_2.1.1     
[16] sessioninfo_1.2.2 modelr_0.1.8      readxl_1.3.1      lifecycle_1.0.1   progressr_0.9.0  
[21] munsell_0.5.0     gtable_0.3.0      cellranger_1.1.0  rvest_1.0.2       memoise_2.0.0    
[26] evaluate_0.14     knitr_1.36        tzdb_0.1.2        fastmap_1.1.0     curl_4.3.2       
[31] fansi_0.5.0       broom_0.7.9       Rcpp_1.0.7        backports_1.2.1   scales_1.1.1     
[36] cachem_1.0.6      jsonlite_1.7.2    fs_1.5.0          hms_1.1.1         digest_0.6.28    
[41] stringi_1.7.5     grid_4.1.1        cli_3.2.0         tools_4.1.1       magrittr_2.0.1   
[46] crayon_1.5.0      pkgconfig_2.0.3   ellipsis_0.3.2    xml2_1.3.2        data.table_1.14.2
[51] reprex_2.0.1      lubridate_1.8.0   rstudioapi_0.13   assertthat_0.2.1  rmarkdown_2.11   
[56] httr_1.4.2        R6_2.5.1          compiler_4.1.1   

[Jeffery-777]

piggy backing on this. I'm finding some names that the first name is logged differently in load rosters for diff years. This is by no means exhaustive but see here

[tanho63]

Thanks! Transferring to roster code repo now.

[tanho63]

Resolved by #54