search

nflverse / nflverse-rosters

builds roster data for nflverse/nflverse-data
Other
20 stars 3 forks source link

Incorrect ESBID for Liam McCullough in roster_weekly_2023.csv file #78

Open DaSkunk opened 6 months ago

DaSkunk commented 6 months ago

Is there an existing issue for this?

Have you installed the latest development version of the package(s) in question?

If this is a data issue, have you tried clearing your nflverse cache?

I am not using an nflverse R package (nflreadr, nflfastR) to access this data.

What version of the package do you have?

This relates to the roster_weekly_2023.csv file

Describe the bug

Tan — Today at 7:27 PM Can you open an issue in nflverse/nflverse-rosters? unsure when we might get to it but it’s good to centralize all issues together

I'm not absolutely certain but there may be a mistake in the roster_weekly_2023.csv in nflverse/nflverse-data under players release. If I am correct I just wanted to bring it to your attention. I think the ESBID for Liam McCullough may be incorrect. Here's a snipit of his entries in the roster_weekly csv.

2023,ATL,LS,LS,49,ACT,Liam McCullough,Liam,McCullough,1997-06-05,74,237,Ohio State,00-0036082,,,,,,,,,3,"[https://static.www.nfl.com/image/private/f_auto,q_auto/league/fdwbtbdsntzlgld87c5w",,14,REG,A01,Liam,MCC769873,52986,3200474f-5204-5716-a75e-4ec8e313a651,2020,2020](https://static.www.nfl.com/image/private/f_auto,q_auto/league/fdwbtbdsntzlgld87c5w%22,,14,REG,A01,Liam,MCC769873,52986,3200474f-5204-5716-a75e-4ec8e313a651,2020,2020),,
2023,ATL,LS,LS,49,ACT,Liam McCullough,Liam,McCullough,1997-06-05,74,237,Ohio State,00-0036082,,,,,,,,,3,"[https://static.www.nfl.com/image/private/f_auto,q_auto/league/fdwbtbdsntzlgld87c5w",,13,REG,A01,Liam,MCC769873,52986,3200474f-5204-5716-a75e-4ec8e313a651,2020,2020](https://static.www.nfl.com/image/private/f_auto,q_auto/league/fdwbtbdsntzlgld87c5w%22,,13,REG,A01,Liam,MCC769873,52986,3200474f-5204-5716-a75e-4ec8e313a651,2020,2020),,

Based on the info in Sunday's game json, coupled with info I have from week 5 pbp_patch_ids_2023.csv, I believe the correct ESBID is 32004d43-4376-9873-8228-cd33f90cba27

Thank you

Reprex

I am not running any code just reading the information from the roster_weekly_2023.csv file

Expected Behavior

NA

nflverse_sitrep

NA

Screenshots

NA

Additional context

No response

mrcaseb commented 6 months ago

You are absolutely right.

The PBP ID 3200474f-5204-5716-a75e-4ec8e313a651 hashes Anthony Gordnon's ESB ID GOR045716. The correct PBP ID is 32004d43-4376-9873-8228-cd33f90cba27 which hashes MCC769873, the ESB ID of Liam McCullough