Suggestion for better test_indices

nfmcclure / tensorflow_cookbook

Code for Tensorflow Machine Learning Cookbook

https://www.packtpub.com/big-data-and-business-intelligence/tensorflow-machine-learning-cookbook-second-edition

MIT License

6.24k stars 2.41k forks source link

Suggestion for better test_indices #119

Open ychong opened 6 years ago

ychong commented 6 years ago

Hi I would like to propose a better implementation for 'test_indices':

We can remove the unneeded np.array casting:

Cleaner/New: test_indices = list(set(range(len(texts))) - set(train_indices))

Old: test_indices = np.array(list(set(range(len(texts))) - set(train_indices)))

nfmcclure commented 6 years ago

Thanks! I'll look into this. Do you know where specifically you want this changed?

ychong commented 6 years ago

Hi Nick thanks for replying. Yes I didn't make it clear earlier. It's just clearer syntax. You can change it under Chapter 07 Neural Network - improving_linear_regression.py, and other similar implementation as well.

12744746 commented 4 years ago

Hi Everyone could you please let me know for the classification part is the following data set suitable to build classification model for point Cloud. https://shapenet.cs.stanford.edu/media/modelnet40_ply_hdf5_2048.zip,

thanks