XCP Guest tools

[marcusbooyah]

VM tools are not getting installed for XCP/XenServer nodes.

[jefflill]

CLOSING: These are being installed but XenCenter seems to report that they aren't installed for more advanced CPUs with better virtualization capabilities.

[jefflill]

I'm looking at this once again. The code to install guest tools is still present, but this note for XCP-ng says that Ubuntu has not been publishing the required APT package since Ubuntu 20.02:

https://xcp-ng.org/docs/guests.html#linux

We also install the tools from the XenServer host by mounting the tools ISO and running a install script there, so this should work but apparently is not. I'm going to walk thru the process manually. We may also need to enable/start the service:

systemctl enable xe-linux-distribution.service
systemctl start xe-linux-distribution.service

I'm also following up on the guest services integration for Hyper-V. It looks like this has been integrated info modern kernels for some time now, so I don't think we need to do anything special here:

https://learn.microsoft.com/en-us/windows-server/virtualization/hyper-v/Supported-Linux-and-FreeBSD-virtual-machines-for-Hyper-V-on-Windows

[jefflill]

Required XenServerImageHost changes:

• [x] There's no need to uninstall hv-kvp-daemon.service. This is no longer being installed.
• [x] We're mounting the guest-tools ISO from /dev/dvd; this needs to be /dev/cdrom
• [x] We're trying to report errors from the install script but need to add set -e so we'll actually see any errors
• [x] I believe we can remove NodeSshProxy.BaseInstallGuestIntegrationServices() now

[jefflill]

FIXED