nfprojects / nfengine

Game engine
GNU General Public License v2.0
56 stars 4 forks source link

Improve tests.py script #157

Closed Witek902 closed 8 years ago

Witek902 commented 8 years ago
lookeypl commented 8 years ago

I do agree with second point, however only when this will be kept within one line. I do not want "quiet mode" in tests to spam the console output.

mkulagowski commented 8 years ago
  1. Sleep was only for animation purpose, so it does look like an animation instead of psycho-fan
  2. Animation is kept in one line (text is just overwritten) and so will be those lines with testcases.
  3. So which one should it be? Should it go per single test (e.x. x64 nfCoreTest, win32 nfCoreTest, etc) or per single execution of tests.py ?
lookeypl commented 8 years ago
  1. I do agree and we thought so too. However, this increases the time of our test execution drastically. That's why we decided to remove it.
  2. :+1:
  3. TBH I think this should be an additional thing, with --time option or sth (of course if @Witek902 agrees). If you provide --time, it should print both times - per test and overall.

As for the task, I added some one more bonus enhancement that went through my head recently.

Witek902 commented 8 years ago

:+1:

mkulagowski commented 8 years ago

Okay, I've done all that's been left to do in this commit.

...of course apart from this, as it is already included (--args option):

Passing additional arguments to test executables. For example nfRendererTest accepts --renderer flag.

mkulagowski commented 8 years ago

Merged.

Please update the description and close the issue.

Witek902 commented 8 years ago

What about the last point?

lookeypl commented 8 years ago

The lines are shortened as well, and -v is added. Closing, GJ