nfrechette / rtm

Realtime Math
MIT License
732 stars 44 forks source link

refactor(scalar): defining param as const by renaming it to scalarf_arg0 #147

Closed GermanAizek closed 1 year ago

GermanAizek commented 1 year ago

Hello @nfrechette, constant parameter declaration may have been missed, judging by typedef in headers.

commit-lint[bot] commented 1 year ago

Code Refactoring

Contributors

GermanAizek

Commit-Lint commands
You can trigger Commit-Lint actions by commenting on this PR: - `@Commit-Lint merge patch` will merge dependabot PR on "patch" versions (X.X.Y - Y change) - `@Commit-Lint merge minor` will merge dependabot PR on "minor" versions (X.Y.Y - Y change) - `@Commit-Lint merge major` will merge dependabot PR on "major" versions (Y.Y.Y - Y change) - `@Commit-Lint merge disable` will desactivate merge dependabot PR - `@Commit-Lint review` will approve dependabot PR - `@Commit-Lint stop review` will stop approve dependabot PR
CLAassistant commented 1 year ago

CLA assistant check
All committers have signed the CLA.

nfrechette commented 1 year ago

Good catch! You are correct, I must have missed it by mistake. I'd appreciate if you could edit the commit message and PR name to meet the commit linter guidelines. You can look at other commits in the history for inspiration, the PR format is the same. In the meantime, I'll approve workflow runs.

GermanAizek commented 1 year ago

@nfrechette, Hi, I've been busy for a week, now I'll fix commit names according to documentation.

GermanAizek commented 1 year ago

@nfrechette, done fix commit here https://github.com/nfrechette/rtm/pull/147/commits/e2a502a943f3e9b369e0773909c9ebaa96f92dd4

nfrechette commented 1 year ago

@all-contributors add @GermanAizek as code

allcontributors[bot] commented 1 year ago

@nfrechette

I've put up a pull request to add @GermanAizek! :tada:

nfrechette commented 1 year ago

Thank you for your contribution!