search

nfriedly / node-bestzip

Provides a `bestzip` command that uses the system `zip` if avaliable, and a Node.js implimentation otherwise.
MIT License
80 stars 16 forks source link

Linked folders not followed #10

Closed Lampei closed 4 years ago

Lampei commented 6 years ago

On Windows, when subfolders are "symlink" folders rather than the actual folders, bestzip does not follow them to get their contents.

Lampei commented 6 years ago

It looks like the latest version of archiver supports symlinks. Is there a reason for bestzip only using v0.21 ? Looks like they're up to 2.0.0 now.

peacechen commented 6 years ago

Probably because no one's updated it :)

If you don't mind updating, testing and creating a PR, we'll merge and release the new version.

Lampei commented 6 years ago

Once my sprint's finished (today), I'll try upgrading and see what happens...

Lampei commented 6 years ago

I've reviewed the code and bulk was removed starting with 2.0.0 in archiver, so the code will need some updating in order to work correctly (and testing). I tried just updating to v1.3.0, but that still did not fix the issue with links.

Lampei commented 6 years ago

I created a pull request for this issue. Only change was to "matches" from ** to **/**. If we updated the archiver to latest, there would be many things to test and a completely different way of handling the directory zipping.

peacechen commented 6 years ago

Thanks @Lampei . I just remembered that you have merge permissions too :)

As long as it continues to work on Windows as well as Linux, I vote to merge it.

Lampei commented 6 years ago

It has definitely been working for me in Windows, but I don't have a *nix machine to test that side of things with.

nfriedly commented 4 years ago

This is now fixed in v2.1.6