Closed jeswinsimon closed 6 years ago
As per the changelog of Archiver, the bulk
method was removed in version 2.0.0.
bestzip 1.1.5 upgarded to Archiver 2.1.1 whereas the previous version uses Archiver 0.21.0.
Observed the same issues as @jeswinsimon - OS independent as expected. Recreated the issue on CentOS.
Yup, this was why in this issue https://github.com/nfriedly/node-bestzip/issues/10 I had to use a different method. Until the code is updated to use something other than "bulk" we are still reliant on the older archiver.
Hey everyone, sorry about this. v1.1.6 should fix it.
There was a PR to update to the latest version of archiver yesterday to resolve a security issue, and the tests passed... But it turned out that we didn't have any tests covering the 'bulk' path. I added a test suite for that, confirmed that it worked with the old archiver@0.21 and failed as expected with the archiver@latest. Then I tested on archiver@1 and it passed there, so that's what I stuck with.
v1.1.6 will be out once CI finishes that should work the same as v1.1.4, except hopefully without the security issue that #18 was trying to resolve.
Compressing a directory using version 1.1.5 throws the following error:
Environment: OS: Windows 10 Node 6.10.3 npm 3.10.10