Empty directories are not zipped

nfriedly / node-bestzip

Provides a `bestzip` command that uses the system `zip` if avaliable, and a Node.js implimentation otherwise.

MIT License

80 stars 16 forks source link

Empty directories are not zipped #28

Open s-pic opened 5 years ago

s-pic commented 5 years ago

I figured out that if I do not put a file in a directory, it will not go into the archive. Is there some sort of option I can use?

Here is what I am doing: cd build && bestzip ../myproject-build.zip * .env.example

/build contains files, subfolders with files and also empty subfolders.

I am on a windows machine.

nfriedly commented 5 years ago

Hi @geomC,

Can you try running the command with --force=node and --force=native and let me know what the results are for each variation?

nfriedly commented 5 years ago

Actually, nevermind. I made a test case that reproduces the bug, so now I just need to figure out how to fix it.

Kovvah commented 3 years ago

...2 years later ahah

No fix planned ? This issue is blocking me in my delivery process :(

nfriedly commented 3 years ago

Sorry, this was from right before my daughter was born, and everything got more or less forgotten after that.

If you can come up with a fix (and hopefully a test, since I'm not sure what happened to the one I made), I can get it merged in and shipped pretty soon.