search

nfriedly / node-bestzip

Provides a `bestzip` command that uses the system `zip` if avaliable, and a Node.js implimentation otherwise.
MIT License
81 stars 17 forks source link

Ignore stderr message if no native zip #33

Closed BenRussert closed 5 years ago

BenRussert commented 5 years ago

This will prevent stderr from showing confusing zip not recognized message: "no zip found message"

on windows when bestzip is still working, but will use node zip instead.

nfriedly commented 5 years ago

Hey @BenRussert thanks, this is a good idea!

The linter is complaining about formatting, you can run npm run lint-fix and it'll straighten it out automatically. After that, I think we can merge this in and release it.

BenRussert commented 5 years ago

Hey @BenRussert thanks, this is a good idea!

The linter is complaining about formatting, you can run npm run lint-fix and it'll straighten it out automatically. After that, I think we can merge this in and release it.

Thanks for the quick reply, glad you are happy with the change and thanks for the nice useful (and cross platform) utility!

nfriedly commented 5 years ago

Awesome! I'm on my phone right now, so I can merge, but not release. I'll get the release out soon.

BenRussert commented 5 years ago

🚢 🚢 :shipit:

nfriedly commented 5 years ago

So sorry! I forgot about this. It should be released in v2.1.5 by Travis CI shortly.