Follow linked folders - Githubissues

nfriedly / node-bestzip

Provides a `bestzip` command that uses the system `zip` if avaliable, and a Node.js implimentation otherwise.

MIT License

80 stars 16 forks source link

Follow linked folders #36

Closed dworthen closed 3 years ago

dworthen commented 4 years ago

Upgrade archiver dependency to 4.x
Resolves #10
- Add test cases for symlink directories and files.
- Follow symlink directories and files.
- Tested on Windows 10 node 12.16.1 and on Ubuntu 18.04 node 12.16.1 with and without native zip.

nfriedly commented 3 years ago

Nice! (and, sorry for the delay)

I'd prefer for walkDir() be asynchronous, but since this solves an existing issue, I'm going to merge it in now and leave that for the future. I'd love another PR for that, but no worries if you don't have the time.

nfriedly commented 3 years ago

This should be published in v2.1.6 once the CI loop finishes