search

nfriedly / node-bestzip

Provides a `bestzip` command that uses the system `zip` if avaliable, and a Node.js implimentation otherwise.
MIT License
80 stars 16 forks source link

Zip fails if the destination is inside the folder to be zipped #39

Open llorenspujol opened 4 years ago

llorenspujol commented 4 years ago

Issue

When zipping a folder and setting it's output to be in the same exact folder, the process never ends, gets indefinitely pending.

Example:

bestzip dist/app/app.zip dist/app/*

Output:

Writing dist/app/* to dist/app/app.zip... (never ends until the process is manually stopped)

Comments

Not big issue, but in my case is the output I desire. If it can be easily fixed by code or by showing some error it would be nice for future users.

If someone is here with the same issue just create the .zip outside the zipping folder and move it later on.

Environment

Windows 10, Node 12.7.0

nfriedly commented 4 years ago

Ah, yea, that running on forever is a problem. It should either error or at least warn and skip the destination file. What does the native zip command do? Do you want to send a PR to copy that behavior?