search

nfriedly / node-bestzip

Provides a `bestzip` command that uses the system `zip` if avaliable, and a Node.js implimentation otherwise.
MIT License
81 stars 17 forks source link

Update deps to latest version #43

Closed j0k3r closed 3 years ago

j0k3r commented 3 years ago

Add Node 12 & 14 in Travis.

Here are the missing one (for now):

$ npm outdated
Package                 Current  Wanted  Latest  Location
eslint                   5.16.0  5.16.0  7.22.0  bestzip
eslint-config-prettier    4.3.0   4.3.0   8.1.0  bestzip
prettier                 1.19.1  1.19.1   2.2.1  bestzip
nfriedly commented 3 years ago

Hey @j0k3r, thanks for this!

I think it's mostly good, although since bestzip is pretty heavily dependent on archiver, I do want to know if whatever constituted a breaking change in archiver should also be published as a breaking change here.

eslint and friends can also be updated, although that might necessitate an increase in the minimum node.js version that we test against. ESLint tends to be pretty aggressive about adopting new node.js features.

j0k3r commented 3 years ago

The only breaking change from archiver is https://github.com/archiverjs/node-archiver/pull/433:

absolute glob patterns are not supported: archiver.glob('*.txt',{cwd: '/tmp'}) has to be used instead of archiver.glob('/tmp/*.txt')

But I don't think it affects bestzip.

About ESLint, for now there are sill allowing Node 10:

Prerequisites: Node.js (^10.12.0, or >=12.0.0)

I'll work on upgrading ESLint and their friends too

nfriedly commented 3 years ago

Should be published as v2.2.0 shortly