search

nfriedly / node-bestzip

Provides a `bestzip` command that uses the system `zip` if avaliable, and a Node.js implimentation otherwise.
MIT License
80 stars 16 forks source link

New maintainer? #9

Closed nfriedly closed 5 years ago

nfriedly commented 6 years ago

Would anyone like to volunteer to help maintain this?

This thing is apparently rather buggy (it never uses the native zip method, for starters), and I'm no longer actually using the library. I don't feel like I have the time to properly maintain it right now, but I know that other people are using it.

The first thing it needs, aside from fixing it to actually use the native zip command, is some proper tests. Travis CI can test on OS X and Linux. I'm not sure about Windows, but there isn't a built-in zip command, so at least we don't have to worry about that.

I'm tagging people who have sent PRs in the past. If you're interested in helping out or taking over, let me know and I'll grant you access. Otherwise you can ignore this.

@Lampei @ooXavier @JeffDownie @peacechen

peacechen commented 6 years ago

Hi @nfriedly . Thanks for creating this package and offering to open it up to others. I'm game for being a collaborator on this repo to help merge PR's. It would also help to add the same people as collaborators to the package on npm so we can publish updates.

I'm not actively using it either but it's a handy project and I could see leveraging it in the future.

Lampei commented 6 years ago

Yeah, sure. I'm using it on a current project, so I'd be up for being a collaborator or maintainer. Either way works for me. Seems like a pretty popular package, so tests for updates and pull requests would certainly make sense.

nfriedly commented 6 years ago

That's a good point @peacechen. Ideally the CI should automatically publish to npm after the tests pass, but that's not set up currently, and you should always be able to manually publish anyways. Let me know your npm username and I'll set you up on both. (I'm heading out in a minute, so it might be later today before I get it all set.)

peacechen commented 6 years ago

My npm username is 'peace' https://www.npmjs.com/~peace

Thanks again @nfriedly

Lampei commented 6 years ago

and my npm username is 'lampei' https://www.npmjs.com/~lampei

Thanks!

nfriedly commented 6 years ago

Ok, you should both have commit permission on github and publish permission on npm. Thanks!

Lampei commented 6 years ago

I got the npm access, and I responded to the request in github, but I think it still just shows me as "Contributor" for bestzip. Not sure if there's something else I need to do.

nfriedly commented 6 years ago

Hum.. try going here and see if it will let you accept again: https://github.com/nfriedly/node-bestzip/invitations

Lampei commented 6 years ago

Excellent! Thanks! Showing correctly now.