search

nfriess / carrier_infinity

Carrier Infinity Thermostat Controller
GNU General Public License v3.0
4 stars 1 forks source link

Client / Server Merge #1

Closed njobrien1006 closed 2 years ago

njobrien1006 commented 2 years ago

-Merged Client and Server into single application. -Using HomeAssistant-Infintiude's Climate.py adapted to the Python's Server call and matched up. -Added Pushover Support for notifications and energy stats. -Tried to finish out other calls my thermostat was making instead of just sending 404.

njobrien1006 commented 2 years ago

@nfriess Due to the large structural changes wasn't sure if this should be merged or just remain a fork? Or if this project was still being utilized/maintained?

nfriess commented 2 years ago

@njobrien1006 Thanks for the contribution. In general your PR looks great. Please give me some time over the holiday to test you changes with my thermostat and understand a couple of the pieces in more detail. If everything works out then I will accept your PR.

njobrien1006 commented 2 years ago

@nfriess I think the majority of your points have been addressed.

I noticed that in the UI there are two buttons underneath the thermostat control that are new but don't work. They are the circle arrows and the power button. Could they be hidden if they are not implemented?

These buttons are the set_hvac_mode I don't use them as I only really change activities. I changed them to just Log an error instead of throwing an error.