search

nfroidure / gulp-iconfont

Create icon fonts from several SVG icons
MIT License
854 stars 72 forks source link

Drop dependency on gulp-util #158

Closed ohbarye closed 6 years ago

ohbarye commented 6 years ago

Hello maintainers.

This closes https://github.com/nfroidure/gulp-iconfont/issues/157

Thanks.

ohbarye commented 6 years ago

Thank you! 😄

gRoussac commented 6 years ago

Dear all,

I understand that you removed the dependency to gulp@2.2.20 here but "gulp-spawn": "^0.4.0" seems to still make use of this version 2.2.20

https://github.com/hparra/gulp-spawn/pull/16

Best regards

demurgos commented 6 years ago

@gRoussac This PR removes gulp-util, not gulp. I am not sure how this is related to gulp-spawn: could you clarify?

Do you mean that this plugin no longer works with gulp 2? If so I'd recommend you to evaluate the pros and cons to migrating to the latest version of Gulp. Gulp 2 is no longer supported so related issue will be ignored, migrating may take you some time - shouldn't be too much I hope. I don't think there are security issues so if Gulp 2 works and your project is not actively maintained, it may be reasonable to stick with Gulp 2.