search

nfroidure / midifile

A MIDI file parser/writer using ArrayBuffers
http://karaoke.insertafter.com
MIT License
199 stars 30 forks source link

Incorrect path to webMIDIAPIShim in tests/index.html. Incorrect handling of midiOutput #12

Closed argiepiano closed 8 years ago

argiepiano commented 8 years ago

I'm very new at this, so please bear with me and let me know if I'm doing anything incorrectly.

I noticed that, in the tests/index.html, the path to the SHIM is incorrect.

Also the assignment of the output port using midiAccess.outputs is incorrectly handled - the latest SHIM and the native Web MIDI API in Chrome handle .outputs as a "maplike Interface", not a function (in fact Chrome throws an error in ln 188 in the original file saying that outputs is not a function).

I've forked the project and made a few changes to this file. I'll do a pull request. Again, let me know if this is not what I'm supposed to do :)

argiepiano commented 8 years ago

I did a pull request fixing this issue in test/index.html. Closing...