Closed ronyeh closed 6 years ago
Thanks for reporting, will try to find some time to do it.
Just started a new project using this and this issue is in the way. @nfroidure I saw in a commit that you deleted the gruntfile. Do you have an intention to use another task manager to do the build or it was an accident? Either way, I'm available to help if you don't have the time ;)
@graciano it is using browserify https://github.com/nfroidure/MIDIFile/blob/master/package.json#L34
Feel free to improve this repo, it was just a side project, i only used it for this poc: http://karaoke.insertafter.com/ ;)
If you want to help maintain i can add you to collaborators on GH and NPM so you'll have no constraints for your changes.
@nfroidure ok, I just built it here and tested. Everything running all right.
Hi @nfroidure, I'm using your Midifile.js library, but the latest npm release still has the bug reported by @ronyeh. Could you release a new version on npm? Thank you so much!
Hi @pcan. I just refreshed this module and published a 2.0.0 version. Major bump is only for remove old Node versions support.
Btw, I you use this library and want to help maintain it, feel free to. The code base really needs to be improved/modernized.
Hi, @nfroidure, thank you for your fast response!
I accidentally used the JS file in your dist directory. Later, I realized you had some bug fixes that never made it into the dist.
For example:
event.subtype === type
You fixed this bug a while back, but I spent an afternoon trying to figure out why my parsing wasn't working! Haha. I traced it to the subtype filtering, and thought I found a cool bug for you to fix. Alas, it was already fixed!
Anyways, tldr: you can update your dist build when you have free time. ;-)