search

nfroidure / midifile

A MIDI file parser/writer using ArrayBuffers
http://karaoke.insertafter.com
MIT License
199 stars 30 forks source link

Accept UInt8Arrays and thus, Node.js Buffers #25

Closed mk-pmb closed 7 years ago

mk-pmb commented 7 years ago

Took me quite a while to understand that I had been mislead by the readme's variable name, anyBuffer – I thought the module just wouldn't support the flavor of MIDI file format. Now at least standard buffers (as from fs.readFile) do work.

I had to skip linting because npm run lint seems to not work on my machine: It found a whole screen full of problems even in original master (c322a1aa7c47a42f491798d1a27a4b8e85a642a5).

Code quality

[x] I made some tests for my changes

[x] I'm a nice person

My NPM username: mk-pmb

nfroidure commented 7 years ago

Thanks for your help. Added you as a contributor + npm user.

mk-pmb commented 7 years ago

You're welcome. Thanks for providing the nice package! :+1: PS: Is master ready for a release to npm?