Replace node:punycode with punycode.js due to deprecate - Githubissues

nfroidure / svgicons2svgfont

Concatenate SVG icons and ouput an SVG font

http://nfroidure.github.io/svgiconfont/

MIT License

337 stars 71 forks source link

Replace node:punycode with punycode.js due to deprecate #171

Closed ianlauyin closed 2 months ago

ianlauyin commented 2 months ago

Fixes #

Replacing node:punycode with punycode.js due to Ref: https://nodejs.org/api/punycode.html

Code quality

[ ] I made some tests for my changes
[ ] I added my name in the contributors field of the package.json file.

License

To get your contribution merged, you must check the following.

[x] I read the project license in the LICENSE file
[x] I agree with publishing under this project license

Join

[ ] I wish to join the core team
[ ] I agree that with great powers comes responsibilities
[ ] I'm a nice person

andersk commented 15 hours ago

We can actually remove punycode completely:

173