nfroidure / svgicons2svgfont

Concatenate SVG icons and ouput an SVG font
http://nfroidure.github.io/svgiconfont/
MIT License
340 stars 71 forks source link

Use the the SVGPathData.getBounds() function. #74

Closed NaridaL closed 7 years ago

NaridaL commented 7 years ago

Only 2 tests were actually affected: originalicons6.svg and originalicons7.svg. The paths were offset slightly to the right, which is what was expected. I loaded them up in a font viewer and they seemed ok. The previous bounds calculation was encoding and re-parsing the glyphs, I changed that, which resulted in most tests needing slight whitespace changes. Also changed a manual path concat (x + '/' + y), which was breaking on windows.

Code quality

License

To get your contribution merged, you must check the following.

narida on npm, add me and I'll merge/publish this myself.

nfroidure commented 7 years ago

Hi guys, merged the changes but feel free to act by yourself since I'm not that involved now. I'll try to help as much as I can, don't wait for my approval on changes you find useful/necessary.

NaridaL commented 7 years ago

@nfroidure I would, but I don't have write access here.