nfroidure / ttf2woff2

Convert ttf files to woff2.
MIT License
303 stars 40 forks source link

package.json: Add back missing binding.gyp and csrc #63

Closed andersk closed 3 years ago

andersk commented 3 years ago

Commit 0657e8df60fa5b984406cf0d33b86c64c759a2c8 incorrectly removed these from the distributed package. As a result, ttf2woff2@4.0.0 fails to install.

> ttf2woff2@4.0.0 install /tmp/test/node_modules/ttf2woff2
> ((node-gyp configure && node-gyp build) > builderror.log) || (exit 0)

gyp: binding.gyp not found (cwd: /tmp/test/node_modules/ttf2woff2) while trying to load binding.gyp
gyp ERR! configure error 
gyp ERR! stack Error: `gyp` failed with exit code: 1
gyp ERR! stack     at ChildProcess.onCpExit (/nix/store/papk5mxa4npj3m83w9qlk91yr9rwns0r-nodejs-14.15.1/lib/node_modules/npm/node_modules/node-gyp/lib/configure.js:351:16)
gyp ERR! stack     at ChildProcess.emit (events.js:315:20)
gyp ERR! stack     at Process.ChildProcess._handle.onexit (internal/child_process.js:277:12)
gyp ERR! System Linux 5.9.12
gyp ERR! command "/nix/store/papk5mxa4npj3m83w9qlk91yr9rwns0r-nodejs-14.15.1/bin/node" "/nix/store/papk5mxa4npj3m83w9qlk91yr9rwns0r-nodejs-14.15.1/lib/node_modules/npm/node_modules/node-gyp/bin/node-gyp.js" "configure"
gyp ERR! cwd /tmp/test/node_modules/ttf2woff2
gyp ERR! node -v v14.15.1
gyp ERR! node-gyp -v v5.1.0
gyp ERR! not ok 

Proposed changes

Code quality

License

To get your contribution merged, you must check the following.

Join

My NPM username: andersk

andersk commented 3 years ago

(I’m not sure if the metapak.data configuration also needs to be updated somehow. That appears to be related to your metapak-nfroidure setup.)

nfroidure commented 3 years ago

@andersk indeed, it would override the files on the next run. I just published a patch with those changes added via metapak.

Let me know if it still doesn't work.