search

nftchef / art-engine

An advanced fork of the HashLips Art Engine with additional features to generate complex art from provided layers using the familiar Hashlips setup.
MIT License
427 stars 203 forks source link

bypassDNA value on this line is undefined. Error/Mistake #293

Open null-prophet opened 1 year ago

null-prophet commented 1 year ago

Looking a the code here:

https://github.com/nftchef/art-engine/blob/884bc739678ee07e0d14297738d015e712bbac66/src/main.js#L138

It looks like the options.bypassDNA value doesn't really set properly as the the value its setting isn't defined.

Wasn't sure if this was a problem before in the code or added in changes.

nftchef commented 1 year ago

will look into it. do you have a use case to reproduce the issue?

null-prophet commented 1 year ago

well I was coding and I was seeing errors in my linter for the bypassDNA variable being undefined.

I think its missing from the function signature.

looking at this clone of the same block of code its been cleaned up/removed:

https://github.com/jalagar/animated-art-engine/blob/main/step2_spritesheet_to_generative_sheet/src/main.js#L136