nfthashi / monorepo

This is NFTHashi monorepo repository

nfthashi.vercel.app

4 stars 3 forks source link

chore: txHistories #107

Closed Aqrare closed 2 years ago

Aqrare commented 2 years ago

Each link to each explorer

This is a minimum tx history. I would update UI and display after

68

vercel[bot] commented 2 years ago

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name	Status	Preview	Updated
nfthashi	✅ Ready (Inspect)	Visit Preview	Jul 27, 2022 at 10:24AM (UTC)

taijusanagi commented 2 years ago

I think this history should not appear in page directory, you can refer the uniswap UI. This is better to be in modal.

taijusanagi commented 2 years ago

Also, txHash could be too long to display, it seems like it is not displayed properly in mobile view. You can truncate the string. example.

export const truncate = (str: string | undefined, pre: number, post?: number) => {
  if (!str) {
    return "";
  }
  const _post = post || 0;
  const len = pre + _post;
  if (str.length <= len) {
    return str;
  }
  return `${str.substring(0, pre)}...${post ? str.substring(str.length - post) : ""}`;
};

And I think we can just show short txHash and link to etherscan and connext scan is enough. I mean we don't have to show the connect hash in string.

Aqrare commented 2 years ago

Thanks for your reviewing!

This is better to be in the modal.

This is a good design I think too! Once I'll close this issue and merge temporarily and 'll create a new issue to display it in modal cause we have to do more important issue

You can truncate the string. example.

At about this, I'll fix this issue & PR because it is not displayed properly in the mobile view

Aqrare commented 2 years ago

@taijusanagi @ksuhara I've fixed it and hope you two'll take it lightly!

Aqrare commented 2 years ago

I moved tx history to the account profile. Both PC and Phone looks good