Closed daroczig closed 5 years ago
Thanks, @nfultz!
If you need this ASAP you can merge it in, otherwise there's a couple parts I'd like to refactor
No rush with the merge, I'm using my fork/branch.
But I'm a bit worried about the above mentioned error in the client -- probably I'll spend some more time with extra error handling, but could really use some help there if you get a chance.
^^ hey @nfultz , the above added demo on health check + combining services is not highly related, but I hope you don't mind including it here
Yeah that looks good too - I probably wouldn't have thought of c()
ing two services together, I like that.
Sorry for the slow turn around, plan is to get this merged on sunday craft day.
@nfultz this PR is getting our of control a bit :) OK to merge so that I can open actual feature/fix branches from now on? Or should I rather maintain my own dev
branch.
Good call.
Example run with starting the demo server + 1 run of the demo client:
PS the motivation behind this was to be able to run the server with port set to
0
so that gRPC will pick an available port instead of hard-coding it.