Enable calling with metadata

nfultz / grpc

gRPC clients and servers in R

74 stars 24 forks source link

Enable calling with metadata #27

Closed noodlesblue closed 5 years ago

noodlesblue commented 5 years ago

Adding callWithMetadata that allows accepts metadata. This also includes the fix for a bug handling semicolons in the proto file.

daroczig commented 5 years ago

the unit test seems to be broken with the 3.x.x version of processx -- seems to be unrelated to this PR

nfultz commented 5 years ago

@sieverssj @noodlesblue Thank you for the patch - overall I like it quite a bit. I think it would be simpler to make metadata an optional argument on fetch rather than having separate fetch and fetchWithMetadata functions. All my other comments are minor/style preferences.

nfultz commented 5 years ago

Awesome! I'm going to merge this in and bump the version.