search

nfultz / grpc

gRPC clients and servers in R
74 stars 24 forks source link

Can read_services use readProtoFiles2 which has an equivalent of proto_path for imports? #29

Open sagadasgupta opened 4 years ago

sagadasgupta commented 4 years ago

I have a proto file that has a few imports on proto files in other packages and readProtoFiles simply blows up with errors because it doesn't know where to find the imports. readProtoFiles2 was introduced to fix that issue https://github.com/eddelbuettel/rprotobuf/issues/39 and https://www.rdocumentation.org/packages/RProtoBuf/versions/0.4.14/topics/readProtoFiles. So can read_services use readProtoFiles2 and allow us to specify proto_path?

nfultz commented 4 years ago

This seems very reasonable to me; would you need to modify read_services declaration to have proto_path as a parameter also, or can you change only the one line in read_services?

sagadasgupta commented 4 years ago

I think since read_services will call readProtoFiles2 it will have to accept and pass the proto_path to readProtoFiles2.