WIP Support configurable client deadlines

nfultz / grpc

gRPC clients and servers in R

74 stars 24 forks source link

WIP Support configurable client deadlines #30

Open Shehab7osny opened 4 years ago

Shehab7osny commented 4 years ago

I did the following updates to solve the issue related to client-side deadline. I hope that these updates solve the problem. I tried my updated code on the example (Helloserver and Helloclient) and it worked perfectly. I think it will work on any other example too.

Shehab7osny commented 4 years ago

Should we use the ubuntu build of grpc as well? Or is it too old?

Well, according to my knowledge and some research, I think it is possible to use the ubuntu build of grpc. I didn't try to implement it in the yaml file yet, but I will definitely try and let you know the results!

Shehab7osny commented 4 years ago

Regarding this PR, I will try to drop the less-important updates and leave out the important ones only. However, the TLS encryption update was automatically included to this PR as well, but I will try to remove any updates related to TLS encryption from this PR too and add them to a separate PR for better organization.

nfultz commented 4 years ago

Overall this is looking pretty good.

A couple minor points on organization

if they are only included in one file, no need to split out server_libraries.h to a separate header file
No need for testthat - it won't interact correctly with client/servers anyway - we can just write r scripts directly for tests - use base::stopifnot() as replacement for expect etc
TLS scripts should be moved to a folder called src/TLS - this will be included in the final package tarball, src will not

Other todo's:

Knitr document in vignettes/ - can reuse content from blog post.
Add logging hooks for TLS, Oauth on server side
double check code style