search

nfultz / grpc

gRPC clients and servers in R
72 stars 24 forks source link

Add docker and automated tests #7

Closed daroczig closed 6 years ago

daroczig commented 6 years ago

This is WIP

daroczig commented 6 years ago

Getting closer to the automated tests, but there are still some minor issues to be solved at https://travis-ci.org/daroczig/grpc/builds/284182412

So just a heads up that I'll continue working on this, pls do not merge, this is not stable.

daroczig commented 6 years ago

screenshot from 2017-10-07 01-24-38

^^ I think this is ready for review, @nfultz :)

If you set up the Travis linking, we should also switch the references to your repo in the PR, just let me know

nfultz commented 6 years ago

I flipped the switch at https://travis-ci.org/nfultz/grpc/settings so I think it will run? Never set up travis myself before.

daroczig commented 6 years ago

Yeah, I think that's enough, as this PR already have a .travis.yml file, so after merging this, it should be OK. Note that the Docker img is still in my namespace, so if you expect to update the Dockerfile too, then you should create an automated build on dockerhub

daroczig commented 6 years ago

All set :tada: