nfultz / grpc

gRPC clients and servers in R
72 stars 24 forks source link

docker for using debian builds of grpc #8

Closed nfultz closed 6 years ago

nfultz commented 6 years ago

@daroczig

daroczig commented 6 years ago

If we want to stick with the slightly outdated debian apt packages and not sticking with our custom defined versions, I'm totally fine with this -- left some suggestions how to simplify the dockerfile. Note: I did not manage to build grpc from source on debian due to openssl 1.1 as mentioned at https://github.com/nfultz/grpc/pull/7#discussion_r143340644 and c49918731b6180361e7876f661fbf16ad4611e35

nfultz commented 6 years ago

Theres some value in having both a "stable" build and a "dev" build, I'd rather maintain a docker file than install.md.

nfultz commented 6 years ago

Cleaned up docker_stable per your recommendations, next I'll set up a dockerhub acct and wire it up.

nfultz commented 6 years ago

OK, I have the dockerhub set up, I think, so I'm going to merge this in now.

nfultz commented 6 years ago

https://hub.docker.com/r/rgrpc/grpc_dev/

daroczig commented 6 years ago

Very cool :+1: Let me know if I can help with anything here.