search

nfx / slrp

rotating open proxy multiplexer
MIT License
170 stars 26 forks source link

Why the https_proxy.go and http_proxy.go aren't used. #108

Open tur11ng opened 1 year ago

tur11ng commented 1 year ago

I inspected that the https_proxy.go and http_proxy.go files don't have any usages except for testing. Is there a reasoning behind this? Will they be part of a future update?

tungtrinh1402 commented 1 year ago

i also test many times and the certificate always fails. remote error: tls: unknown certificate.

tur11ng commented 1 year ago

@tungtrinh1402 You have to add the CA signing certificate to your HTTPS client. It is recommended to open a new issue about it. You can check inside the ca.go file and add your custom certificate export function. Otherwise you have to set your HTTPS client to ignore the certificate chain trust issues (e.g. accept custom signed certificates).

tungtrinh1402 commented 1 year ago

@st1064870 I have been using slrp for a long time as a proxy host, all proxies work fine except for https proxy accuracy. there are real https proxies that can't connect but still work. Also do you have any suggestions for modifying the code for faster rechecking of detected proxies? Got proxies 3 days ago but still haven't checked if the proxy is still working.

nfx commented 1 year ago

@st1064870 Yes, eventually the issue with validating https proxies will be fixed. It's not those two files, but rather hidden deep in the custom net.ContextDialer implementation that we use for making connections. Don't have cycles for that yet, would be good if community picks it up and makes a PR.

nfx commented 1 year ago

@st1064870 @tungtrinh1402 Why do you need to re-test the proxies?

The whole idea of slrp is that you use it as your http proxy (localhost:8090) and let's re-route connections under the hood, without having to worry about checking things.

What are your use-cases?

nfx commented 1 year ago

@tungtrinh1402 I hope you don't recommit found proxies to public repos.

tungtrinh1402 commented 1 year ago

@nfx I personally use my software. The problem with re-testing proxies is that there are proxies that haven't re-tested for a long time, even tested 1 week ago but not checked again whether the proxy is working or not. I know that proxypool is a public environment and there will be proxies that will die within minutes.