search

ng-alain / ng-zorro-vscode

Visual studio code plugin for ng-zorro
https://marketplace.visualstudio.com/items?itemName=cipchk.ng-zorro-vscode
MIT License
54 stars 16 forks source link

feat: Added button,empty,modal #15

Closed gs-akhan closed 4 years ago

gs-akhan commented 4 years ago

Adding missing components

gs-akhan commented 4 years ago

@cipchk Also can you consider adding me contributor to this repo, I can work on adding all remaining attributes as well.

I use ngzorro very extensively and can help in improving this extension. Thanks

gs-akhan commented 4 years ago

@cipchk need a merge. :)

cipchk commented 4 years ago

Sorry, thanks for pr.

But I can’t merge him, because of these behaviors you can be very simple and intelligent, like this nz-button:

demo

gs-akhan commented 4 years ago

Hi, Thanks for the feedback. Can you elaborate little more on whats wrong ? Because the button doesnt work with existing code. Screenshot 2020-10-09 at 11 20 03 AM

cipchk commented 4 years ago

@gs-akhan Your upload fail of screenshots, pls check it.

gs-akhan commented 4 years ago

re uploaded.

cipchk commented 4 years ago

You can try to reinstall the extension, if it still, try to check if there is any error from the developer tool of vscode.

gs-akhan commented 4 years ago

Sure, However can you please add modal to the extension or should I make another PR for that. ?

On Fri, Oct 9, 2020 at 11:43 AM 卡色 notifications@github.com wrote:

You can try to reinstall the extension, if it still, try to check if there is any error from the developer tool of vscode.

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/ng-alain/ng-zorro-vscode/pull/15#issuecomment-705990382, or unsubscribe https://github.com/notifications/unsubscribe-auth/ABLCOVWS7MTR4ZQPPOHXSO3SJ2SY3ANCNFSM4SDOUT6A .

gs-akhan commented 4 years ago

@cipchk please add modal, that will help us a lot .

cipchk commented 4 years ago

@gs-akhan If you want to make some code snippets for project, you can try this https://marketplace.visualstudio.com/items?itemName=cipchk.vscode-snippet-generator