ng-andre / pe

0 stars 0 forks source link

Null is accepted as valid input for ID #2

Open ng-andre opened 2 years ago

ng-andre commented 2 years ago

image.png

Input ID null may cause problems with other systems, and should be rejected

Steps to reproduce: Input null into any field when adding a new item of any category

Expected output: data will be rejected when null is specified

Actual output: null field is not rejected

nus-se-script commented 2 years ago

Team's Response

The values of all attributes are treated literally, as this provides flexibility for users or librarians to utilise the application in managing their catalogues.

With this context, null should be treated as a completely valid input for ID as some libraries may choose to implement naming conventions for IDs that may result in null being a ID for a particular item.

As such, the application behaves as expected.

Items for the Tester to Verify

:question: Issue response

Team chose [response.Rejected]

Reason for disagreement: null is commonly used to indicate the lack of a value or unknown value in a certain field. In that case, if null is accepted for the libaries to implement as a ID name to indicate no ID for an item for whatever reason, if there is more than one item without an ID, which is not unrealisitic, there would be a rejection of duplicate. Therefore, either duplicate IDs have to be allowed for null, or null should be a rejected input