ng-andre / pe

0 stars 0 forks source link

Duplicate IDs with extra leading zeros are accepted as valid input #7

Open ng-andre opened 2 years ago

ng-andre commented 2 years ago

image.png

Adding an identical item with the same fields, only with an extra 0 in front of the ID, will not result in a duplicate item. This could lead to potential confusion for the user, especially due to erroneous extra input or inconsistent data input eg when reading from physical data.

Expected behaviour: Duplicate item will be rejected or warning will be issued about duplicate item

Actual behaviour: No warning is shown, duplicate item can be added as per normal

soc-pe-bot commented 2 years ago

Team's Response

The team feels that even in such cases, the program should not perform checking of such cases. This is because we understand that different libraries have different naming conventions for items within their catalogues and in certain cases, a particular library may feel that a leading 0 should indicate a different item.

Primarily, the team feels that part of the responsibility should be on the user in terms of entering the IDs of items. The reduced amount of input validation was also an attempt by the team to maximise compatibility in terms of libraries with differing ID systems and naming conventions.

Items for the Tester to Verify

:question: Issue response

Team chose [response.Rejected]

Reason for disagreement: [replace this with your explanation]