ngbAccordionCollapse does not collapse when ngbAccordionItem is disabled

DanielRose commented 8 months ago

Bug description:

When an ngbAccordionItem is disabled, the ngbAccordionCollapse is not collapsed (and the content is not disabled). This is a breaking change from the component-based accordion.

Compare the "Custom header" demo in the current version with the old release (https://ng-bootstrap.github.io/releases/13.x/#/components/accordion/examples).

Link to minimally-working StackBlitz that reproduces the issue:

Based on the default "Custom header" demo: https://stackblitz.com/edit/angular-oz5acv?file=src%2Fapp%2Faccordion-header.html,src%2Fapp%2Faccordion-header.ts:

Open the third panel
The button can be clicked
Click on the "Disable third" button on the second panel
The third panel's header is disabled, but the panel remains open, and the button can be clicked!

Versions of Angular, ng-bootstrap and Bootstrap:

Angular: 17.0.9

ng-bootstrap: 16.0.0

Bootstrap: 5.3.2

maxokorokov commented 4 months ago

Seems like a breaking change indeed.

I'm not sure this should change, but at least reviewed along with #4658.

mentossez commented 3 months ago

Hello, I am new here, can I start looking into this issue?

ng-bootstrap / ng-bootstrap